Bug #8
closed
canbus-binding: BMS signals verbs aren't accessible via Binder Devtool on openSUSE 15.3
Added by Emmanuel Jubera [SAFT] over 2 years ago.
Updated over 2 years ago.
Description
When starting canbus-binding on openSUSE 15.3 with command "afb-binder --name=afb-canbus-binding --workdir=/var/local/lib/afm/applications/canbus-binding --binding=lib/afb-canbus-binding.so --port=9999 -vvv", API canbus complains when trying to add verb for each signal (please refer to attached file for complete logs):
WARNING: [API canbus] You got problem adding verb for the signal BMS_ISD_MSRS_V14.0/. Ignoring! [/home/abuild/rpmbuild/BUILD/canbus-binding-1.0.1+20210813+3+g031ebb86/low-can-binding/binding/low-can-cb.cpp:1033,add_verb]
As a result, BMS signals verbs aren't accessible via Binder Devtool.
The same works on a Fedora VM running May 2021 software.
Files
- Assignee changed from Vincent Rubiolo to José Bollo
From the log file I can tell that the name of the verb is BMS_ISD_MSRS_V14.0/. for all signal. It seems to be wrong and I suggest to check the configuration file.
Also Emmanuel, could you provide more information on the setup which works for you (the "Fedora VM running May 2021 software"), especially:
- The version of the package in that environment (
afb-binder, canbus2bms-plugins, etc)
- The version of the Fedora OS
- How you setup this environment (I suspect this is the one which we shipped but wanted to confirm w/ you).
Thanks much!
- Status changed from New to Submitter feedback needed
- Assignee changed from José Bollo to Vincent Rubiolo
3) Yes Vincent, this is the Fedora VM you shipped ;)
2) Linux vm-redpesk-native-dev 5.10.20-200.fc33.x86_64 #1 SMP Thu Mar 4 13:18:27 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
1)
afb-binder-4.0.1-10.AGL.rpd33.x86_64
canbus-plugins-bms-0.0.0+20210414+202717+0+g27a3206-1.saft_1af346cb.rpd33.x86_64
canbus-binding-9.99.2-18.AGL.rpd33.x86_64
1. Explanation¶
The Problem is due to an incompatibility of service version. Indeed, the canbus-plugin-bms was developed for the datahub project where it comes with an 'old' canbus-binding service version. Your use case was trying to test datahub components outside of the datahub project context.
2. Issue¶
The way to generate the BMS plugin shared library uses a JSON file to configure canbus messages. Moreover the canbus-binding uses this shared library to create these verbs. Unfortunately, with the newest version of this binding, the JSON file needs to contain the message name with the key name. Previously it was with the key generic_name.
3. Fix¶
To fix the problem, in the canbus-plugin-bms, we need to switch all messages name keys from generic_name to name.
- "generic_name": "BMS.Main.Param.Bat.SWMajorVer",
+ "name": "BMS.Main.Param.Bat.SWMajorVer",
Fixed on the commit 58116d5829cb2dd7f67e80d494ad391d9f840ac0
- Status changed from Submitter feedback needed to Resolved
- Assignee changed from Vincent Rubiolo to Emmanuel Jubera [SAFT]
Fix validated.
A "make" wasn't enough to regenerate the plugin, I rebuilt everything from scratch...
- Status changed from Resolved to Closed
Also available in: Atom
PDF